-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Handle infer -> dyn unsizing directly in the trait solver #138598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
oli-obk
wants to merge
1
commit into
rust-lang:master
from
oli-obk:remove-hacky-unsize-inference-hint
Closed
Handle infer -> dyn unsizing directly in the trait solver #138598
oli-obk
wants to merge
1
commit into
rust-lang:master
from
oli-obk:remove-hacky-unsize-inference-hint
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 17, 2025
…e-hint, r=<try> Remove hacky inference hint in unsizing This was introduced in rust-lang#56219 for unblocking (rust-lang#49593) never type stabilization, which never (heh) happened. cc `@WaffleLapkin` for never types I am trying to simplify unsizing coercions to get closer to rust-lang#50753 (using the trait solver instead of manually running trait solver steps). This one stood out as particularly annoying to do in the trait solver, so I want to remove it for now and once rust-lang#50753 is resolved try to add it again reopens rust-lang#49593 r? `@compiler-errors`
The job Click to see the possible cause of the failure (guessed by this bot)
|
Hm I don't see a good way to do this in the old solver without implication bounds stating |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #56219 for unblocking (#49593) never type stabilization, which never (heh) happened.
I am trying to simplify unsizing coercions to get closer to #50753 (using the trait solver instead of manually running trait solver steps).
r? @compiler-errors